Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(main): sync cert for cert cmd #3891

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix(main): sync cert for cert cmd #3891

merged 1 commit into from
Sep 18, 2023

Conversation

cuisongliu
Copy link
Collaborator

@cuisongliu cuisongliu commented Sep 11, 2023 •
edited by ghost
Loading

🤖 Generated by Copilot at 247f7df

Summary

🐛🔄🔐

Fix certificate and kubeconfig synchronization bug for master nodes. Refactor pkg/runtime/kubernetes/certs.go to use a new function k.syncCert that generates and copies certificates and kubeconfigs for all master nodes.

Oh we're the masters of the cluster, we keep it running smooth
We sync the certs and kubeconfigs, we know just what to do
We use the function k.syncCert, it does the job for all
And when we add new SANs or nodes, we heed the captain's call

Walkthrough

  • Add a new function k.syncCert to synchronize the certificates and kubeconfigs of all the master nodes after adding a new SAN to the API server certificate (link in pkg/runtime/kubernetes/certs.go)

@cuisongliu cuisongliu added this to the v4.4 milestone Sep 11, 2023
This was linked to issues Sep 11, 2023
Is there something wrong with etcd certs #3708
Closed
BUG: sealos cert generate wrong DNS altnames for HA etcd clusters #3887
Closed
@sealos-ci-robot
Copy link
Member

sealos-ci-robot commented Sep 11, 2023 •
edited
Loading

🤖 Generated by lychee action

Summary

Status Count
🔍 Total 930
✅ Successful 390
⏳ Timeouts 0
🔀 Redirected 0
👻 Excluded 539
❓ Unknown 0
🚫 Errors 0

Full action output

Full Github Actions output

@codecov
Copy link

codecov bot commented Sep 11, 2023 •
edited
Loading

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@cuisongliu
fix(main): sync cert for cert cmd
b176266 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
@yangxggo
Copy link
Contributor

2941695010589_ pic

@yangxggo
Copy link
Contributor

2951695010606_ pic

@yangxggo
Copy link
Contributor

2961695010635_ pic

@sealos-ci-robot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

2961695010635_ pic

@yangxggo
Copy link
Contributor

2971695010726_ pic

@sealos-ci-robot
Copy link
Member

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

2971695010726_ pic

@yangxggo
Copy link
Contributor

tested

@zzjin zzjin merged commit cbaf975 into labring:main Sep 18, 2023
@sealos-ci-robot
Copy link
Member

/cherry-pick release-v4.4

@sealos-ci-robot
Copy link
Member

🤖 says: cherry pick action finished successfully 🎉!
See: https://github.com/labring/sealos/actions/runs/6218846504

sealos-ci-robot pushed a commit that referenced this pull request Sep 18, 2023
@cuisongliu
fix(main): sync cert for cert cmd (#3891)
6e0368d 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
@cuisongliu cuisongliu deleted the sync_cert branch September 18, 2023 06:12
cuisongliu added a commit that referenced this pull request Sep 18, 2023
@sealos-ci-robot @cuisongliu
fix(main): sync cert for cert cmd (#3891) (#3951)
2af7a3b 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Co-authored-by: cuisongliu <cuisongliu@qq.com>
@yangxggo yangxggo mentioned this pull request Oct 7, 2023
Merged
bxy4543 pushed a commit to bxy4543/sealos that referenced this pull request Oct 13, 2023
@cuisongliu @bxy4543
fix(main): sync cert for cert cmd (labring#3891)
6e0cbf0 
Signed-off-by: cuisongliu <cuisongliu@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zzjin zzjin zzjin approved these changes

Assignees
No one assigned
Labels
area/lifecycle-management area/runtime size/S
Projects
None yet
Milestone
v4.4
Development

Successfully merging this pull request may close these issues.

BUG: sealos cert generate wrong DNS altnames for HA etcd clusters Is there something wrong with etcd certs
4 participants
@cuisongliu @sealos-ci-robot @yangxggo @zzjin